-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sqllab): Relocate get bootstrap data logic #24936
chore(sqllab): Relocate get bootstrap data logic #24936
Conversation
cc: @EugeneTorap |
Codecov Report
@@ Coverage Diff @@
## master #24936 +/- ##
=======================================
Coverage 68.99% 69.00%
=======================================
Files 1906 1906
Lines 74139 74133 -6
Branches 8208 8211 +3
=======================================
- Hits 51155 51153 -2
+ Misses 20861 20856 -5
- Partials 2123 2124 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0a40017
to
f5b4d48
Compare
Hi @michael-s-molina @john-bodley @villebro! Can you help with this PR? |
To fix the
To fix the import order, just run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @justinpark!
Can we merge it? |
SUMMARY
Part 1 of SQLLab SPA migration: detail link
This commit relocates the existing
_get_sqllab_tabs
to the utils in sqllab in order to share the same logic in the sqllab api v1 endpoint.This commit also refactors the
defaultDBId
by common config parameters which is less relevant to sqlLab root state.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Go to SQLLab and no errors shown
ADDITIONAL INFORMATION