-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: jwks_uri addition to OAUTH provider #24928
Conversation
Updated jwks_uri for generating token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @kravi21 thanks for this! Here's what I'm thinking:
If you can change your comment on that line to be And then the proper fix I believe would be to improve the FAB docs to show how you create a new OAuth provider setup. Can you say what OAuth provider you are using? Maybe we could use that as an example. |
jwks_uri may be required to generate token
@sfirke I have updated the comment as suggested by you, Please review |
jwks_uri token is needed by the OAUTH to fetch the key and create token needed to connect to sso provider.
This will enable the OAUTH to verify the request and process it further.
If this is missing , then sso request was failing to connect to the OPENID type SSO request and will give following error
[Error] authorizing OAuth access token: Missing "jwks_uri" in metadata
Reference: https://stackoverflow.com/questions/72035617/runtimeerror-missing-jwks-uri-in-metadata-for-flask-and-azure-ad-authlib