-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace deprecated command with environment file #24063
Merged
geido
merged 1 commit into
apache:master
from
jongwooo:chore/replace-deprecated-command-with-environment-file
Feb 27, 2024
Merged
chore: Replace deprecated command with environment file #24063
geido
merged 1 commit into
apache:master
from
jongwooo:chore/replace-deprecated-command-with-environment-file
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving CI |
@jongwooo would you be able to rebase this? Hopefully we can get it across the finish line. |
@rusackas Sure :) |
Thanks @jongwooo - running CI jobs now 🤞 |
geido
approved these changes
Feb 27, 2024
@geido Sure thing:) |
Thanks! It is merged now @jongwooo |
9 tasks
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Resolve #24061
Update workflows and shell scripts to use environment file instead of deprecated
set-output
command.For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I found the files that use
set-output
command through the following command:AS-IS
echo "::set-output name=count::$count"
TO-BE
echo "count=$count" >> $GITHUB_OUTPUT
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION