Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated command with environment file #24063

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: Replace deprecated command with environment file #24063

merged 1 commit into from
Feb 27, 2024

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented May 15, 2023

SUMMARY

Resolve #24061

Update workflows and shell scripts to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' -o -name '*.sh'  | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=count::$count"

TO-BE

echo "count=$count" >> $GITHUB_OUTPUT

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas rusackas requested a review from hughhhh June 9, 2023 01:59
@rusackas
Copy link
Member

rusackas commented Jun 9, 2023

Approving CI

@rusackas
Copy link
Member

@jongwooo would you be able to rebase this? Hopefully we can get it across the finish line.

@jongwooo
Copy link
Contributor Author

@rusackas Sure :)

@jongwooo
Copy link
Contributor Author

jongwooo commented Feb 27, 2024

@rusackas #26921 resolved most of the changes, and changed the set-output commands that were still remaining after the rebase.

@rusackas
Copy link
Member

Thanks @jongwooo - running CI jobs now 🤞

@geido geido merged commit e817b48 into apache:master Feb 27, 2024
27 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch February 27, 2024 15:58
eschutho added a commit to preset-io/superset that referenced this pull request Feb 29, 2024
@geido
Copy link
Member

geido commented Feb 29, 2024

Hello @jongwooo it seems this PR introduced an issue. The unit tests did not launch, thus we did not see this failing. Would you be interested to try this again when this PR that launches the tests is merged in? #27297

@jongwooo
Copy link
Contributor Author

@geido Sure thing:)

@jongwooo jongwooo restored the chore/replace-deprecated-command-with-environment-file branch February 29, 2024 09:47
@geido
Copy link
Member

geido commented Feb 29, 2024

Thanks! It is merged now @jongwooo

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
4 participants