Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql-lab] only scroll the result set table #2305

Closed
wants to merge 6 commits into from

Conversation

ascott
Copy link

@ascott ascott commented Mar 1, 2017

before:
sql-lab-table-scrolling-before

after:
sql-lab-table-scrolling

fixes: #2231

todos:

  • make table header fixed

@airbnb/superset-reviewers

@ascott ascott force-pushed the alanna-sql-lab-ui-fixes branch from cd1a4c4 to 9d9e224 Compare March 1, 2017 09:00
@mistercrunch
Copy link
Member

I think there was a related requirement to keep the headers on top. We may want to have a wrapper around the Table component that adds this as an extra prop "fixedHeaders"

@mistercrunch
Copy link
Member

Oh now I'm noticing that the proportion of the page dedicated to viewing data is overall much smaller after the change. There should be a way to first scroll until the headers are at the top of the page, and then only scroll within the dataset.

@ascott
Copy link
Author

ascott commented Mar 2, 2017

with this change i'm trying to duplicate the airpal ui where only results are scrollable.

agreed that the table headers need to remain fixed before merging this in.

airpal-ui

@mistercrunch i remember in an earlier prototype you had added a toggle to resize the results pane and sql editor, we could add that back in as well so users can make the results area larger if they want.

@ascott ascott force-pushed the alanna-sql-lab-ui-fixes branch from 37cf633 to cb98b7a Compare March 16, 2017 07:38
@ascott
Copy link
Author

ascott commented Mar 16, 2017

closing this in favor of two smaller PRs. one for the quick formatting win, and another next week for the refactored table component.

@ascott ascott closed this Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sql-lab] results table ui bug
2 participants