Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removes duplicated Bar Chart when GENERIC_CHART_AXES is enabled #22434

Closed
wants to merge 1 commit into from
Closed

fix: Removes duplicated Bar Chart when GENERIC_CHART_AXES is enabled #22434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
import {
t,
ChartMetadata,
ChartPlugin,
hasGenericChartAxes,
} from '@superset-ui/core';
import transformProps from '../transformProps';
import thumbnail from './images/thumbnail.png';
import example1 from './images/Bar_Chart.jpg';
Expand All @@ -35,7 +40,7 @@ const metadata = new ChartMetadata({
{ url: example2, caption: 'Grouped style' },
{ url: example3 },
],
name: t('Bar Chart'),
name: hasGenericChartAxes ? t('Bar Chart (legacy)') : t('Bar Chart'),
tags: [
t('Additive'),
t('Bar'),
Expand Down