fix: Change dropdown in Alert/Report modal to use javascript for conditional rendering instead of css

[lyndsiWilliams]

SUMMARY

This PR fixes an issue where the alert/report modal was rendering both the dashboard and chart dropdowns in the Message Content section. I fixed this by changing the dropdown conditional to use javascript instead of css.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

• Go to settings -> Alerts & Reports
• Click on the "+ALERT" button
• Observe that there is only one dropdown under the "Message content" section
• Select both "Dashboard" and "Chart" in this section and ensure that the appropriate dropdown is displayed

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[lyndsiWilliams]

/testenv up FEATURE_ALERT_REPORTS=true

[github-actions]

@lyndsiWilliams Ephemeral environment spinning up at http://54.202.30.24:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[lyndsiWilliams]

@jinghua-qa Could you do some QA testing on this to make sure everything looks right?

[codecov]

Codecov Report

Merging #22360 (0fe50f6) into master (04b7a26) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #22360      +/-   ##
==========================================
+ Coverage   66.86%   66.88%   +0.02%     
==========================================
  Files        1846     1847       +1     
  Lines       70510    70604      +94     
  Branches     7723     7755      +32     
==========================================
+ Hits        47144    47225      +81     
- Misses      21364    21372       +8     
- Partials     2002     2007       +5     

Flag	Coverage Δ
hive	52.53% <ø> (ø)
javascript	53.87% <66.66%> (+0.08%)	⬆️
mysql	77.96% <ø> (ø)
postgres	78.02% <ø> (ø)
presto	52.42% <ø> (ø)
python	81.24% <ø> (ø)
sqlite	76.49% <ø> (ø)
unit	50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx	52.79% <66.66%> (+0.70%)	⬆️
...d/src/views/CRUD/data/dataset/AddDataset/index.tsx	51.61% <0.00%> (-8.39%)	⬇️
superset-frontend/src/views/CRUD/data/hooks.ts	57.69% <0.00%> (-5.95%)	⬇️
...a/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx	87.23% <0.00%> (-4.44%)	⬇️
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx	75.00% <0.00%> (-3.58%)	⬇️
...nts/controls/DateFilterControl/DateFilterLabel.tsx	55.31% <0.00%> (-2.83%)	⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx	94.59% <0.00%> (-0.65%)	⬇️
...rontend/src/components/DropdownContainer/index.tsx	72.28% <0.00%> (-0.56%)	⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx	41.07% <0.00%> (-0.20%)	⬇️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx	3.33% <0.00%> (-0.04%)	⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jinghua-qa]

LGTM!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.