-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(native-filters): reduce the re-rendering of native filter modal #21781
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21781 +/- ##
==========================================
- Coverage 66.95% 66.95% -0.01%
==========================================
Files 1807 1807
Lines 69231 69238 +7
Branches 7406 7407 +1
==========================================
+ Hits 46357 46361 +4
- Misses 20966 20968 +2
- Partials 1908 1909 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Can we get @jinghua-qa's approval before merging it?
...-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
Outdated
Show resolved
Hide resolved
...-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
Outdated
Show resolved
Hide resolved
0dd3f10
to
df88336
Compare
SUMMARY
We use
why-did-you-render
tool to measure the re-rendering of the native filter modal. This PR improves native filter modal in two scenarios (which has more than 20 native filters):Enter the dashboard for the first time:
before: 1000+ re-rendering
after: 0 re-rendering
Close the native filter model:
In next PR I will improve the filter configure form in the modal.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION