Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: E2E tests for Drill to Detail supported Charts #21681

Merged
merged 11 commits into from
Oct 5, 2022
Merged

Conversation

geido
Copy link
Member

@geido geido commented Oct 3, 2022

SUMMARY

This PR introduces E2E tests for Tier 1 and Tier 2 charts that currently support D2D, so far:

Tier 1

  • Big number total
  • Big number with trendline
  • Table
  • Pivot Table V2
  • Time-Series Line Chart
  • Time-series Bar Chart V2
  • Time-Series Area Chart
  • Time-Series Scatter Chart
  • Pie
  • World Map

Tier 2

  • Box plot
  • Time-Series Generic Chart
  • Time-Series Smooth Chart
  • Time-Series Step Line Chart
  • Funnel Chart
  • Gauge Chart
  • Mixed Chart
  • Radar Chart
  • Treemap V2

It also fixes some flaky tests related to viz plugins.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #21681 (03886f9) into master (3057e42) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 03886f9 differs from pull request most recent head bb484d0. Consider uploading reports for the commit bb484d0 to get more accurate results

@@            Coverage Diff             @@
##           master   #21681      +/-   ##
==========================================
+ Coverage   66.82%   66.84%   +0.01%     
==========================================
  Files        1799     1799              
  Lines       68867    68930      +63     
  Branches     7314     7331      +17     
==========================================
+ Hits        46022    46075      +53     
- Misses      20966    20976      +10     
  Partials     1879     1879              
Flag Coverage Δ
hive 52.91% <ø> (ø)
javascript 53.16% <ø> (+<0.01%) ⬆️
mysql 78.24% <ø> (?)
postgres 78.30% <ø> (ø)
presto 52.81% <ø> (ø)
python 81.44% <ø> (+0.04%) ⬆️
sqlite 76.80% <ø> (ø)
unit 50.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/supported_charts_dashboard.py 0.00% <ø> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 59.52% <0.00%> (-0.10%) ⬇️
superset/views/core.py 76.06% <0.00%> (+0.45%) ⬆️
superset/models/core.py 90.11% <0.00%> (+0.70%) ⬆️
...src/filters/components/Range/RangeFilterPlugin.tsx 75.47% <0.00%> (+1.88%) ⬆️
superset/db_engine_specs/mysql.py 98.80% <0.00%> (+4.76%) ⬆️
superset/common/utils/dataframe_utils.py 95.23% <0.00%> (+4.76%) ⬆️
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx 49.29% <0.00%> (+6.79%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested D2D tests locally and all worked! Left one non-blocking comment.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 7b66e0b into master Oct 5, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/d2d-e2e-tests branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants