-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: E2E tests for Drill to Detail supported Charts #21681
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21681 +/- ##
==========================================
+ Coverage 66.82% 66.84% +0.01%
==========================================
Files 1799 1799
Lines 68867 68930 +63
Branches 7314 7331 +17
==========================================
+ Hits 46022 46075 +53
- Misses 20966 20976 +10
Partials 1879 1879
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested D2D tests locally and all worked! Left one non-blocking comment.
superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This PR introduces E2E tests for Tier 1 and Tier 2 charts that currently support D2D, so far:
Tier 1
Tier 2
It also fixes some flaky tests related to viz plugins.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION