Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump sqlalchemy-utils to 0.38.3 #21413

Merged
merged 1 commit into from
Sep 10, 2022
Merged

chore: Bump sqlalchemy-utils to 0.38.3 #21413

merged 1 commit into from
Sep 10, 2022

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Recently 0.38.3 version of sqlalchemy-utils added support for Python 3.10

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #21413 (e2a4c55) into master (3197cc6) will decrease coverage by 11.46%.
The diff coverage is n/a.

❗ Current head e2a4c55 differs from pull request most recent head b0fab90. Consider uploading reports for the commit b0fab90 to get more accurate results

@@             Coverage Diff             @@
##           master   #21413       +/-   ##
===========================================
- Coverage   66.52%   55.06%   -11.47%     
===========================================
  Files        1791     1791               
  Lines       68593    68593               
  Branches     7319     7319               
===========================================
- Hits        45630    37769     -7861     
- Misses      21072    28933     +7861     
  Partials     1891     1891               
Flag Coverage Δ
hive 52.94% <ø> (ø)
mysql ?
postgres ?
presto ?
python 57.54% <ø> (-23.69%) ⬇️
unit 50.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/create.py 31.25% <0.00%> (-68.75%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
superset/views/datasource/utils.py 26.66% <0.00%> (-66.67%) ⬇️
superset/reports/commands/execute.py 24.64% <0.00%> (-66.55%) ⬇️
... and 279 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this important bump for 3.10 support. I think I'll switch my devenv to 3.10 (currently on 3.9), and if no issues pop up I think we can start considering deprecating 3.8 like we did this time last year for 3.7, as Python 3.11 is right around the corner.

@villebro villebro merged commit 7401f15 into apache:master Sep 10, 2022
@EugeneTorap EugeneTorap deleted the chore/bump-sqlalchemy-utils branch September 10, 2022 08:48
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants