-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: blankstate metrics columns #20755
Merged
hughhhh
merged 106 commits into
apache:master
from
preset-io:feat-blankstate-metrics-columns
Jul 26, 2022
Merged
feat: blankstate metrics columns #20755
hughhhh
merged 106 commits into
apache:master
from
preset-io:feat-blankstate-metrics-columns
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> columns are loading into page
…ype is Query [41493] Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset Converted ModalTrigger to a functional TypeScript component
> allow for all records to be displayed > fix select with all columns queries > filters are now working
…hart-power-query
…pes from DatasourceTypes options
…/query-preview-modal-for-chart-source-query
…hart-power-query
…view-modal-for-chart-source-query feat: Ericbriscoe/sc 41493/query preview modal for chart source query
… SqlLab and Explore
…set, adds default metric when chart source is query
… datasource A follow on separate effort will enable having a default Count metric when Query is the datasource type
…rset into feat-blankstate-metrics-columns
…eat-blankstate-metrics-columns
AAfghahi
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two nits.
...rset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
Outdated
Show resolved
Hide resolved
...rset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx
Outdated
Show resolved
Hide resolved
…eat-blankstate-metrics-columns
c7877ed
to
dc74d2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #20755 +/- ##
==========================================
- Coverage 66.30% 66.25% -0.05%
==========================================
Files 1757 1757
Lines 66860 66976 +116
Branches 7077 7117 +40
==========================================
+ Hits 44332 44377 +45
- Misses 20719 20782 +63
- Partials 1809 1817 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr updates the blank state to the metrics and columns controls and add a cta for user to save dataset if they using query to power chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
Screen.Recording.2022-06-27.at.11.41.58.PM.mov
TESTING INSTRUCTIONS
Must use a query to power chart in order to test this pr. Create a query from sqllab and then create chart. Check metrics and columns controls and check for updated blank state.
ADDITIONAL INFORMATION