refactor(test): add login_as_admin to global conftest

[ktmud]

SUMMARY

test_client and login_as seems to be two very commonly used utilities for integration tests. Let's move it to global conftest.

Only did this for function-based test suites. Class based test suites should probably be refactor to function-based later.

No visible changes to users.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

• Unit test should still all passes

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20703 (ee7847c) into master (5beb1aa) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head ee7847c differs from pull request most recent head b20260e. Consider uploading reports for the commit b20260e to get more accurate results

@@            Coverage Diff             @@
##           master   #20703      +/-   ##
==========================================
- Coverage   66.83%   66.67%   -0.17%     
==========================================
  Files        1750     1750              
  Lines       65894    65896       +2     
  Branches     7017     7017              
==========================================
- Hits        44041    43936     -105     
- Misses      20067    20174     +107     
  Partials     1786     1786              

Flag	Coverage Δ
hive	?
mysql	82.47% <100.00%> (-0.01%)	⬇️
postgres	82.54% <100.00%> (-0.01%)	⬇️
presto	?
python	82.65% <100.00%> (-0.34%)	⬇️
sqlite	82.35% <100.00%> (+0.01%)	⬆️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/core.py	77.89% <ø> (+0.52%)	⬆️
superset/examples/birth_names.py	72.07% <100.00%> (+0.51%)	⬆️
superset/db_engines/hive.py	0.00% <0.00%> (-85.19%)	⬇️
superset/db_engine_specs/hive.py	70.00% <0.00%> (-15.77%)	⬇️
superset/db_engine_specs/presto.py	83.64% <0.00%> (-5.39%)	⬇️
superset/initialization/__init__.py	89.93% <0.00%> (-1.74%)	⬇️
superset/utils/log.py	93.70% <0.00%> (-1.40%)	⬇️
superset/connectors/sqla/models.py	89.17% <0.00%> (-1.15%)	⬇️
superset/db_engine_specs/base.py	88.00% <0.00%> (-0.34%)	⬇️
superset/models/core.py	88.91% <0.00%> (-0.25%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5beb1aa...b20260e. Read the comment docs.

[ktmud]

The test case test_get_dashboard actually tests dashboard title in the HTML, but the spa doesn't output it anymore. I'm not sure why current master passes the CI. It throws a test error, too, when running locally on my machine.

[ktmud]

Bycatch: asserting for entity counts is probably not a good idea---as the test database can be populated with different data for various reasons. We should test against the actual underlying function itself----which, in this case, is filtering by a couple of text fields.

I caught this because my refactoring failed to clean up charts added in the import/export tests, which has now been fixed.

[bkyryliuk]

nice refactor!