-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds support for clearing the Select cache #20397
feat: Adds support for clearing the Select cache #20397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20397 +/- ##
==========================================
+ Coverage 66.52% 66.70% +0.18%
==========================================
Files 1739 1739
Lines 65141 65135 -6
Branches 6900 6897 -3
==========================================
+ Hits 43336 43451 +115
+ Misses 20052 19931 -121
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -40,7 +41,7 @@ export type PluginFilterGroupByProps = PluginFilterStylesProps & { | |||
data: DataRecord[]; | |||
filterState: FilterState; | |||
formData: PluginFilterGroupByQueryFormData; | |||
inputRef: RefObject<HTMLInputElement>; | |||
inputRef: RefObject<SelectRef>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the inputRef
used anywhere to access attributes from the HTMLInputElement
directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It's used here to automatically focus the filters:
Line 213 in c959d92
inputRef?.current?.focus(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* feat: Adds support for clearing the Select cache * Fixes lint errors
SUMMARY
Adds support for clearing the
Select
cache.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-06-15.at.1.48.16.PM.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION