fix(database-api): allow search for all columns #19662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#19051 broke filtering databases by other than
allow_file_upload
andexpose_in_sqllab
, causing trouble in both SQL Lab and the database list view. This removes the list of explicitsearch_columns
so that filtering by all properties is again possible.AFTER
SQL Lab:
![image](https://user-images.githubusercontent.com/33317356/162934415-f2ec3490-c69f-4f65-908d-8510a994baae.png)
Database list view sorting by AQE:
![image](https://user-images.githubusercontent.com/33317356/162934266-18310180-7d04-41a7-80a6-9d7cf4e7e54a.png)
BEFORE
SQL Lab:
![image](https://user-images.githubusercontent.com/33317356/162933425-87b6eca2-4f08-4f2b-ba16-e57c8eede6c7.png)
Database list view:
![image](https://user-images.githubusercontent.com/33317356/162933526-54768f39-3fa6-42ba-a77a-0c41a1a7d6ca.png)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION