Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sip-68)(wip): Add owners to Dataset Model #19487

Closed
wants to merge 4 commits into from

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Apr 1, 2022

SUMMARY

Adding a new column/relationship for Dataset to have owners. This mapping will be directly tied to how the current SqlaTable.owners is being leveraged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Benchmark:

Results:
Current: 0.44 s
10+: 0.48 s
100+: 0.37 s
1000+: 0.94 s

@hughhhh hughhhh requested a review from a team as a code owner April 1, 2022 14:07
@hughhhh hughhhh force-pushed the add-owners-new-dataset branch from 2365755 to 3522ddf Compare April 1, 2022 15:12
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19487 (3522ddf) into master (eab9388) will decrease coverage by 14.16%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #19487       +/-   ##
===========================================
- Coverage   66.58%   52.42%   -14.17%     
===========================================
  Files        1676     1676               
  Lines       64176    65067      +891     
  Branches     6525     6525               
===========================================
- Hits        42732    34109     -8623     
- Misses      19745    29259     +9514     
  Partials     1699     1699               
Flag Coverage Δ
hive 53.13% <100.00%> (+0.44%) ⬆️
javascript 51.31% <ø> (ø)
mysql ?
postgres ?
presto 53.11% <100.00%> (+0.57%) ⬆️
python 53.53% <100.00%> (-28.85%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_parse.py 62.41% <ø> (-34.97%) ⬇️
superset/datasets/models.py 100.00% <100.00%> (ø)
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/extensions/metastore_cache.py 0.00% <0.00%> (-98.08%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/migrations/shared/utils.py 0.00% <0.00%> (-82.06%) ⬇️
... and 301 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab9388...3522ddf. Read the comment docs.

@hughhhh
Copy link
Member Author

hughhhh commented Apr 11, 2022

In reference to #19421

@mistercrunch mistercrunch deleted the add-owners-new-dataset branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant