-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add drag and drop column rearrangement for table viz #19381
Conversation
Essentially a rebase of the work from the superset-ui repo
Codecov Report
@@ Coverage Diff @@
## master #19381 +/- ##
==========================================
- Coverage 66.67% 66.61% -0.07%
==========================================
Files 1676 1678 +2
Lines 64715 64814 +99
Branches 6506 6522 +16
==========================================
+ Hits 43151 43173 +22
- Misses 19878 19949 +71
- Partials 1686 1692 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I have only a couple of nits.
...tend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/TableStories.tsx
Outdated
Show resolved
Hide resolved
...tend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/TableStories.tsx
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
Outdated
Show resolved
Hide resolved
...tend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/TableStories.tsx
Outdated
Show resolved
Hide resolved
@ktmud let me know if there's anything else you think should be changed! |
@ktmud same with this one. Anything else you think I need to do for this one? |
This looks good. Thanks for your contribution! And sorry for missing your message earlier. |
Awesome, no prob, I'm glad you liked it! |
Bringing this over from superset-ui (some discussion was on the old PR)
apache-superset/superset-ui#1423
SUMMARY
Add the ability for the end user to drag and drop columns for a table visualization
Table designer can enable column rearrangement in the config options when building the table. Then, user can drag columns around
These are volatile changes, so when the browser is refreshed, the column order goes back to default. Demo is in the chart edit page, which is just for simple demonstration purposes. This is intended for the end user to be allowed to rearrange the columns.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
OFF
![dnd_off](https://user-images.githubusercontent.com/70416691/160242444-fae73b3d-315c-4efd-b225-21f80031e064.gif)
ON
![dnd_on](https://user-images.githubusercontent.com/70416691/160242449-3666a274-bf06-455c-8908-751d7510f5fb.gif)
ADDITIONAL INFORMATION