-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(report): add tab selector for dashboard reports #19354
feat(report): add tab selector for dashboard reports #19354
Conversation
8ea526e
to
fdc147a
Compare
Codecov Report
@@ Coverage Diff @@
## master #19354 +/- ##
==========================================
- Coverage 66.80% 66.47% -0.33%
==========================================
Files 1752 1675 -77
Lines 65457 64093 -1364
Branches 6912 6519 -393
==========================================
- Hits 43726 42604 -1122
+ Misses 19982 19798 -184
+ Partials 1749 1691 -58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0c507c1
to
edb8270
Compare
edb8270
to
752ac35
Compare
Partially fixed the merge conflict but the feature is likely now broken. Will test and update |
777c78b
to
82a8ecd
Compare
c098b7d
to
b2c5032
Compare
I will open a new PR to retain the full iteration history. |
SUMMARY
Add Dashboard tab Selector in alert/report config, following the discussion #18475. This feature's backend support is completed by #17749.
TESTING INSTRUCTIONS
CI and manual tests.
FUTURE WORKS
There are a few advanced use-cases are not covered by this PR:
User can select child tab TAB_1b or TAB_2b, but not both TAB_1b and TAB_2b. The reason is that currently dashboard anchor link only support 1 component id. In order to support children from multiple layout branches, we nee dot improve the dashboard anchor feature first.
ADDITIONAL INFORMATION