-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add duckdb as DataSource - Fixes #14563 #19265
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
import re | ||
from datetime import datetime | ||
from typing import Any, Dict, List, Optional, Pattern, Tuple, TYPE_CHECKING | ||
|
||
from flask_babel import gettext as __ | ||
from sqlalchemy.engine.reflection import Inspector | ||
|
||
from superset.db_engine_specs.base import BaseEngineSpec | ||
from superset.errors import SupersetErrorType | ||
from superset.utils import core as utils | ||
|
||
if TYPE_CHECKING: | ||
# prevent circular imports | ||
from superset.models.core import Database | ||
|
||
|
||
COLUMN_DOES_NOT_EXIST_REGEX = re.compile("no such column: (?P<column_name>.+)") | ||
|
||
|
||
class DuckDBEngineSpec(BaseEngineSpec): | ||
engine = "duckdb" | ||
engine_name = "DuckDB" | ||
|
||
# pylint: disable=line-too-long | ||
_time_grain_expressions = { | ||
None: "{col}", | ||
"PT1S": "DATE_TRUNC('second', {col})", | ||
"PT1M": "DATE_TRUNC('minute', {col})", | ||
"PT1H": "DATE_TRUNC('hour', {col})", | ||
"P1D": "DATE_TRUNC('day', {col})", | ||
"P1W": "DATE_TRUNC('week', {col})", | ||
"P1M": "DATE_TRUNC('month', {col})", | ||
"P0.25Y": "DATE_TRUNC('quarter', {col})", | ||
"P1Y": "DATE_TRUNC('year', {col})", | ||
} | ||
|
||
custom_errors: Dict[Pattern[str], Tuple[str, SupersetErrorType, Dict[str, Any]]] = { | ||
COLUMN_DOES_NOT_EXIST_REGEX: ( | ||
__('We can\'t seem to resolve the column "%(column_name)s"'), | ||
SupersetErrorType.COLUMN_DOES_NOT_EXIST_ERROR, | ||
{}, | ||
), | ||
} | ||
|
||
@classmethod | ||
def epoch_to_dttm(cls) -> str: | ||
return "datetime({col}, 'unixepoch')" | ||
|
||
@classmethod | ||
def get_all_datasource_names( | ||
cls, database: "Database", datasource_type: str | ||
) -> List[utils.DatasourceName]: | ||
schemas = database.get_all_schema_names( | ||
cache=database.schema_cache_enabled, | ||
cache_timeout=database.schema_cache_timeout, | ||
force=True, | ||
) | ||
schema = schemas[0] | ||
if datasource_type == "table": | ||
return database.get_all_table_names_in_schema( | ||
schema=schema, | ||
force=True, | ||
cache=database.table_cache_enabled, | ||
cache_timeout=database.table_cache_timeout, | ||
) | ||
if datasource_type == "view": | ||
return database.get_all_view_names_in_schema( | ||
schema=schema, | ||
force=True, | ||
cache=database.table_cache_enabled, | ||
cache_timeout=database.table_cache_timeout, | ||
) | ||
raise Exception(f"Unsupported datasource_type: {datasource_type}") | ||
Comment on lines
+65
to
+89
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This part looks like it can directly inherit the Super Class. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, good catch - There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. made the change here - rwhaling@9fa02d7 |
||
|
||
@classmethod | ||
def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]: | ||
tt = target_type.upper() | ||
if tt in (utils.TemporalType.TEXT, utils.TemporalType.DATETIME): | ||
return f"""'{dttm.isoformat(sep=" ", timespec="microseconds")}'""" | ||
return None | ||
|
||
@classmethod | ||
def get_table_names( | ||
cls, database: "Database", inspector: Inspector, schema: Optional[str] | ||
) -> List[str]: | ||
"""Need to disregard the schema for DuckDB""" | ||
return sorted(inspector.get_table_names()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be better solved on the duckdb-engine side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you would have a better judgment call on that than me; however, this looks to be more or less copy-pasted from the equivalent SQLite datasource - https://github.com/apache/superset/blob/master/superset/db_engine_specs/sqlite.py#L61
so presumably fine for now at least?