Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sql): clean up invalid filter clause exception types #17702

Merged
merged 3 commits into from
Dec 9, 2021
Merged

chore(sql): clean up invalid filter clause exception types #17702

merged 3 commits into from
Dec 9, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 9, 2021 •
edited
Loading

SUMMARY

Sometimes invalid query object extra parameters cause incorrect results. These are now handled correctly in the both the legacy and v1 apis.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #17702 (e45cb52) into master (04e3cfa) will decrease coverage by 0.16%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17702      +/-   ##
==========================================
- Coverage   68.13%   67.97%   -0.17%     
==========================================
  Files        1653     1653              
  Lines       66247    66282      +35     
  Branches     7107     7107              
==========================================
- Hits        45138    45055      -83     
- Misses      19220    19338     +118     
  Partials     1889     1889
Flag Coverage Δ
hive ?
mysql 82.16% <94.59%> (+0.02%) ⬆️
postgres 82.17% <94.59%> (+0.03%) ⬆️
presto ?
python 82.25% <94.59%> (-0.38%) ⬇️
sqlite 81.85% <94.59%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/viz.py 58.13% <75.00%> (+0.07%) ⬆️
superset/common/query_object.py 95.62% <100.00%> (+2.56%) ⬆️
superset/db_engine_specs/postgres.py 97.36% <100.00%> (ø)
superset/exceptions.py 91.42% <100.00%> (+0.16%) ⬆️
superset/sql_parse.py 99.48% <100.00%> (+0.04%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e3cfa...e45cb52. Read the comment docs.

@villebro villebro force-pushed the villebro/parse-filter branch from f5f14db to 646a085 Compare December 9, 2021 10:51
dpgaspar
dpgaspar approved these changes Dec 9, 2021
View reviewed changes
superset/viz.py Show resolved Hide resolved
@villebro villebro force-pushed the villebro/parse-filter branch from 646a085 to bbe8ca7 Compare December 9, 2021 13:45
ofekisr
ofekisr reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@ofekisr ofekisr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add more comments later

superset/sql_parse.py Show resolved Hide resolved
superset/sql_parse.py Outdated Show resolved Hide resolved
superset/sql_parse.py Show resolved Hide resolved
superset/sql_parse.py Show resolved Hide resolved
@villebro villebro merged commit 3a42071 into apache:master Dec 9, 2021
@villebro villebro deleted the villebro/parse-filter branch December 9, 2021 15:49
@eschutho eschutho added the v1.4 label Dec 9, 2021
eschutho pushed a commit that referenced this pull request Dec 11, 2021
@villebro @eschutho
chore(sql): clean up invalid filter clause exception types (#17702)
8b0ab83 
* chore(sql): clean up invalid filter clause exception types

* fix lint

* rename exception
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofekisr ofekisr ofekisr left review comments

@kgabryje kgabryje kgabryje left review comments

@dpgaspar dpgaspar dpgaspar approved these changes

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@villebro @zhaoyongjie @dpgaspar @kgabryje @ofekisr @mistercrunch @eschutho