fix: use typing_extension instead #17174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suddjian
approved these changes
Oct 20, 2021
craig-rueda
reviewed
Oct 20, 2021
| TYPE_CHECKING, | ||
| Union, | ||
| ) | ||
| from typing import Any, Callable, Dict, List, Optional, Type, TYPE_CHECKING, Union |
There was a problem hiding this comment.
Is this compatible with 3.8 AND 3.7?
There was a problem hiding this comment.
yup
➜ python3.7
Python 3.7.12 (default, Oct 13 2021, 06:53:03)
[Clang 13.0.0 (clang-1300.0.29.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from typing import (
Any,
Callable,
Dict,
List,
Literal,
Optional,
Type,
TYPE_CHECKING,
Union,
)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: cannot import name 'Literal' from 'typing' (/usr/local/Cellar/python@3.7/3.7.12_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/typing.py)
>>> from typing import (
Any,
Callable,
Dict,
List,
Optional,
Type,
TYPE_CHECKING,
Union,
)
Codecov Report
@@ Coverage Diff @@
## master #17174 +/- ##
==========================================
- Coverage 76.83% 76.69% -0.14%
==========================================
Files 1039 1039
Lines 55561 55562 +1
Branches 7570 7570
==========================================
- Hits 42690 42615 -75
- Misses 12621 12697 +76
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 20, 2021
(cherry picked from commit aa0f4d6)
|
🏷️ 2021.40 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 22, 2021
(cherry picked from commit aa0f4d6)
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 27, 2021
(cherry picked from commit aa0f4d6)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use
from typing_extensions import Literalinstead offrom typing import Literalto support legacy versions of pythonBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION