-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Explore): Undefined owners #17167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17167 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 1039 1039
Lines 55559 55561 +2
Branches 7567 7570 +3
=======================================
+ Hits 42733 42735 +2
Misses 12576 12576
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://54.218.248.133:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Looks like it works in testing! |
It would probably be a good thing to revisit this one day to make things more aligned/consistent between frontend and backend and simplify some of this logic. |
Ephemeral environment shutdown and build artifacts deleted. |
* Reconcile owners data * Fix on save (cherry picked from commit f580f6b)
🏷 2021.40 |
* Reconcile owners data * Fix on save (cherry picked from commit f580f6b)
* Reconcile owners data * Fix on save (cherry picked from commit f580f6b)
* Reconcile owners data * Fix on save
SUMMARY
This PR fixes the following issues:
The problem arose from the fact that the data related to the owners is very inconsistent and comes in three forms:
[{id: number; first_name: string; last_name: string;}]
[{value: number; label: string;}]
number[]
This PR checks for the different data types to make it work. However, a deeper refactor is required to make the data consistent in both the frontend and the backend
Follow-up of #17063
BEFORE
before.mp4
AFTER
after.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION