-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Exclude SUPERSET_DEFAULT from the list of available color schemes #17018
Conversation
…issue_16962_dup_d3category10
Codecov Report
@@ Coverage Diff @@
## master #17018 +/- ##
==========================================
- Coverage 76.94% 76.89% -0.05%
==========================================
Files 1030 1031 +1
Lines 55088 55179 +91
Branches 7480 7506 +26
==========================================
+ Hits 42385 42430 +45
- Misses 12452 12497 +45
- Partials 251 252 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a non-blocking suggestion.
…ontrol.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ontrol.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
apache#17018) * Handle SUPERSET_DEFAULT theme * Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
#17018) * Handle SUPERSET_DEFAULT theme * Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 14b7f6c)
apache#17018) * Handle SUPERSET_DEFAULT theme * Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
SUMMARY
The SUPERSET_DEFAULT theme should not be considered as an independent color scheme as it is just a reference to an existing color scheme that is already part of the list of schemes. This PR excludes the SUPERSET_DEFAULT from the options of color schemes while keeping retro-compatibility with those that use SUPERSET_DEFAULT as a scheme.
BEFORE
See issue #16962
AFTER
Color.scheme.tes.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION