fix(native-filters): emitted filter label format

[villebro]

SUMMARY

The fix in #16460 didn't address the special case of numeric filter values sometimes being temporal filters. It also introduced a new util for formatting filter values whose functionality was already covered by the much more comprehensive getDataRecordFormatter factory function, which also handles time and number formatting. The redundant formatter is removed and replaced by getDataRecordFormatter which was already being used for formatting the options in the Select component. This will ensure that the filter indicator displays identical values as the Select component.

Closes #16808

AFTER

BEFORE

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16828 (4d5a502) into master (c933250) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4d5a502 differs from pull request most recent head b60bd14. Consider uploading reports for the commit b60bd14 to get more accurate results

@@           Coverage Diff           @@
##           master   #16828   +/-   ##
=======================================
  Coverage   76.99%   77.00%           
=======================================
  Files        1018     1018           
  Lines       54668    54660    -8     
  Branches     7456     7452    -4     
=======================================
- Hits        42094    42091    -3     
+ Misses      12329    12324    -5     
  Partials      245      245           

Flag	Coverage Δ
javascript	71.09% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/filters/utils.ts	93.33% <ø> (+8.14%)	⬆️
...c/filters/components/Select/SelectFilterPlugin.tsx	81.11% <100.00%> (+0.21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c933250...b60bd14. Read the comment docs.

[villebro]

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

[github-actions]

@villebro Ephemeral environment spinning up at http://54.184.7.171:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[stephenLYZ]

LGTM！

[jinghua-qa]

LGTM

[zhaoyongjie]

LGTM, Thanks for the fix.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[sadpandajoe]

🏷️ 2021.38