-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set importer as owner #16656
fix: set importer as owner #16656
Conversation
2b1f5eb
to
f74d33b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if there is a usecase where you wouldn't want this new behaviour by default upon importing and instead allow customizing the owner
@amitmiran137 like having the option to assign someone else as the owner? |
Yes. Upon load dashboards in new environments |
f74d33b
to
70eb714
Compare
Codecov Report
@@ Coverage Diff @@
## master #16656 +/- ##
=======================================
Coverage 76.76% 76.77%
=======================================
Files 1007 1007
Lines 54125 54133 +8
Branches 7374 7374
=======================================
+ Hits 41550 41558 +8
Misses 12335 12335
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* fix: set importer as owner * Fix tests
* fix: set importer as owner * Fix tests
Fixes #17467 |
SUMMARY
When importing a dataset, chart or dashboard, add the importer to the list of owners.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION