-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Writes the tests for the new Select component #16638
chore: Writes the tests for the new Select component #16638
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16638 +/- ##
==========================================
+ Coverage 76.64% 76.74% +0.09%
==========================================
Files 1003 1004 +1
Lines 53959 53971 +12
Branches 7330 7335 +5
==========================================
+ Hits 41358 41418 +60
+ Misses 12362 12314 -48
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing work! ❤️ This should really help protect us against regressions and make it easier to add new features and refinements without fear of breaking existing functionality.
const firstOption = OPTIONS[0]; | ||
const secondOption = OPTIONS[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: some of these might look nicer by doing the ol'
const firstOption = OPTIONS[0]; | |
const secondOption = OPTIONS[1]; | |
const [firstOption, secondOption] = OPTIONS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is stellar work!
* chore: Writes the tests for the new Select component * Uses array destructuring
* chore: Writes the tests for the new Select component * Uses array destructuring
SUMMARY
Writes the tests for the new Select component and fixes the bugs found while writing the tests.
@junlincc @rusackas
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
All tests should pass.
ADDITIONAL INFORMATION