test: RTL overhaul - hackathon #16626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16626 +/- ##
==========================================
+ Coverage 76.71% 76.86% +0.14%
==========================================
Files 1002 1004 +2
Lines 53801 53970 +169
Branches 6858 7374 +516
==========================================
+ Hits 41276 41482 +206
+ Misses 12288 12248 -40
- Partials 237 240 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
approved these changes
Sep 17, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* CachedLabel_spec fully converted to RTL * ColumnTypeLabel_spec fully converted to RTL * MissingChart_spec fully converted to RTL * RefreshIntervalModal_spec mostly converted to RTL * HoverMenu_spec mostly converted to RTL * ResizableContainer_spec fully converted to RTL * ResizableHandle_spec fully converted to RTL * AggregateOption_spec fully converted to RTL * CheckboxControl_spec fully converted to RTL * ColorPickerControl_spec to RTL * Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS * Added unknown type to ColumnTypeLabelProps * Fixed ColumnTypeLabel_spec
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* CachedLabel_spec fully converted to RTL * ColumnTypeLabel_spec fully converted to RTL * MissingChart_spec fully converted to RTL * RefreshIntervalModal_spec mostly converted to RTL * HoverMenu_spec mostly converted to RTL * ResizableContainer_spec fully converted to RTL * ResizableHandle_spec fully converted to RTL * AggregateOption_spec fully converted to RTL * CheckboxControl_spec fully converted to RTL * ColorPickerControl_spec to RTL * Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS * Added unknown type to ColumnTypeLabelProps * Fixed ColumnTypeLabel_spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate Enzyme test files to React Testing library/Typescript and improve test case quality. See the project description doc for more details.
TESTING INSTRUCTIONS
Migrate to the following files and observe the tests converted to RTL/TS:
superset-frontend/spec/javascripts/components/CachedLabel_spec.tsxsuperset-frontend/spec/javascripts/components/ColumnTypeLabel_spec.tsxsuperset-frontend/spec/javascripts/dashboard/components/MissingChart_spec.tsxsuperset-frontend/spec/javascripts/dashboard/components/RefreshIntervalModal_spec.tsxsuperset-frontend/spec/javascripts/dashboard/components/menu/HoverMenu_spec.tsxsuperset-frontend/spec/javascripts/dashboard/components/resizable/ResizableContainer_spec.tsxsuperset-frontend/spec/javascripts/dashboard/components/resizable/ResizableHandle_spec.tsxsuperset-frontend/spec/javascripts/explore/components/AggregateOption_spec.tsxsuperset-frontend/spec/javascripts/explore/components/CheckboxControl_spec.tsxsuperset-frontend/spec/javascripts/explore/components/ColorPickerControl_spec.tsxADDITIONAL INFORMATION