Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dashboards and Charts drop a red 'Unexpected error' message for anonymous users #16538

Closed
wants to merge 0 commits into from

Conversation

trepmag
Copy link
Contributor

@trepmag trepmag commented Sep 1, 2021

Fix #16507...

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #16538 (ffadfcf) into master (80c39da) will increase coverage by 0.01%.
The diff coverage is 78.43%.

❗ Current head ffadfcf differs from pull request most recent head f7d332f. Consider uploading reports for the commit f7d332f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16538      +/-   ##
==========================================
+ Coverage   76.72%   76.73%   +0.01%     
==========================================
  Files        1002     1003       +1     
  Lines       53798    53875      +77     
  Branches     6858     7291     +433     
==========================================
+ Hits        41274    41343      +69     
- Misses      12287    12292       +5     
- Partials      237      240       +3     
Flag Coverage Δ
javascript 70.99% <47.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/filters/components/GroupBy/index.ts 60.00% <ø> (ø)
...set-frontend/src/filters/components/Range/index.ts 90.00% <ø> (ø)
...et-frontend/src/filters/components/Select/index.ts 90.00% <ø> (ø)
...rset-frontend/src/filters/components/Time/index.ts 100.00% <ø> (ø)
...rontend/src/filters/components/TimeColumn/index.ts 90.00% <ø> (ø)
...frontend/src/filters/components/TimeGrain/index.ts 90.00% <ø> (ø)
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 93.18% <ø> (ø)
superset/db_engine_specs/rockset.py 53.12% <ø> (+1.60%) ⬆️
superset/db_engine_specs/__init__.py 50.00% <25.00%> (ø)
superset-frontend/src/components/Select/Select.tsx 72.45% <36.36%> (-2.32%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c39da...f7d332f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboards and Charts drop a red 'Unexpected error' message when user is anonymous
1 participant