fix: Revert "chore: Changes the DatabaseSelector and TableSelector to use the new Select component" #16478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16478 +/- ##
==========================================
- Coverage 76.61% 76.25% -0.37%
==========================================
Files 1002 1002
Lines 53674 53787 +113
Branches 6855 6870 +15
==========================================
- Hits 41123 41015 -108
- Misses 12312 12535 +223
+ Partials 239 237 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Aug 26, 2021
|
@etr2460 You can revert it. No problem at all. I'll search for the problem and re-submit as soon as possible 👍🏼 |
michael-s-molina
approved these changes
Aug 26, 2021
|
Un an unrelated note, the conventional commit topic of the original PR should be "refactor:" not "chore:". |
Merged
9 tasks
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Aug 29, 2021
* upstream/master: fix: create example DB if needed (apache#16451) fix(native-filters): add handle undefined control value gracefully (apache#16468) Revert "chore: Changes the DatabaseSelector to use the new Select component (apache#16334)" (apache#16478) fix(explore): JS error for creating new metrics from columns (apache#16477) fix: queryEditor bug (apache#16452) docs: make code snippet usable with required imports (apache#16473) perf(dashboard): decouple redux props from dashboard components (apache#16421) perf(dashboard): reduce number of rerenders of Charts (apache#16444)
|
🏷 2021.34 |
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 31, 2021
…ponent (apache#16334)" (apache#16478) This reverts commit c768941. (cherry picked from commit 8adc31d)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…ponent (apache#16334)" (apache#16478) This reverts commit c768941.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…ponent (apache#16334)" (apache#16478) This reverts commit c768941.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16334
This is the root cause PR for the issue here: #16475. Reverting as opposed to fixing forward since this was a pretty big PR and i unfortunately don't have the time to dig into a fix. Hope that's ok!
to: @michael-s-molina @lilykuang @graceguo-supercat @ktmud