fix(datasets): add support for removing owners

[villebro]

SUMMARY

Currently removing all owners from the datasets modal raises the following error:

This makes the following changes to the endpoint:

• When OLD_API_CHECK_DATASET_OWNERSHIP config is set to the default value (True), we both check ownership and make sure the user doesn't lock themselves out of the object. See feat(dao): admin can remove self from object owners #15149 for more details on how this works for Admin vs regular users
• When the OLD_API_CHECK_DATASET_OWNERSHIP config flag is set to False, the behavior is unchanged (other than fixing the error when datasource_dict["owners"] == None). Note that in this scenario, a user is able to both edit datasets that they don't own and also save without adding themselves to the list of owners. See fix(datasets): add support for removing owners #16461 for context on this FF.

AFTER

TESTING INSTRUCTIONS

1. Login as Admin
2. Open the dataset modal for a dataset you own
3. Remove yourself as owner
4. See the error

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16461 (88c305a) into master (62d8ab7) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

❗ Current head 88c305a differs from pull request most recent head 1c6b699. Consider uploading reports for the commit 1c6b699 to get more accurate results

@@            Coverage Diff             @@
##           master   #16461      +/-   ##
==========================================
- Coverage   76.63%   76.58%   -0.06%     
==========================================
  Files        1002     1002              
  Lines       53680    53684       +4     
  Branches     6852     6852              
==========================================
- Hits        41138    41112      -26     
- Misses      12305    12335      +30     
  Partials      237      237              

Flag	Coverage Δ
hive	?
mysql	81.48% <50.00%> (-0.01%)	⬇️
postgres	81.50% <50.00%> (-0.05%)	⬇️
presto	81.34% <50.00%> (?)
python	81.81% <50.00%> (-0.11%)	⬇️
sqlite	81.19% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/datasource/views.py	90.10% <50.00%> (-1.85%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	69.80% <0.00%> (-16.87%)	⬇️
superset/utils/core.py	89.76% <0.00%> (-0.13%)	⬇️
superset/models/core.py	89.40% <0.00%> (+0.25%)	⬆️
superset/connectors/sqla/models.py	89.46% <0.00%> (+1.18%)	⬆️
superset/db_engine_specs/presto.py	90.37% <0.00%> (+5.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d8ab7...1c6b699. Read the comment docs.

[zhaoyongjie]

Code LGTM, a little concern if we have to avoid users to removing all owners ?

[jinghua-qa]

🏷 2021.34

[zhaoyongjie]

LGTM