Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve embedded data table in text reports #16335

Merged
merged 4 commits into from
Aug 19, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

This PR improves the data table that is embedded in the email/slack notifications as text for reports.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2021-08-18 at 2 21 39 PM

After:

Screen Shot 2021-08-18 at 2 21 49 PM

TESTING INSTRUCTIONS

Create a report as "text" and send to email.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested review from lilykuang, eschutho and hughhhh and removed request for lilykuang August 18, 2021 21:29
Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #16335 (09b9d01) into master (7a284bb) will decrease coverage by 0.27%.
The diff coverage is 69.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16335      +/-   ##
==========================================
- Coverage   76.65%   76.37%   -0.28%     
==========================================
  Files         999     1000       +1     
  Lines       53394    53458      +64     
  Branches     6817     6817              
==========================================
- Hits        40929    40831      -98     
- Misses      12228    12390     +162     
  Partials      237      237              
Flag Coverage Δ
hive ?
mysql 81.54% <69.84%> (-0.09%) ⬇️
postgres 81.56% <69.84%> (-0.13%) ⬇️
presto ?
python 81.65% <69.84%> (-0.55%) ⬇️
sqlite 81.17% <69.84%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/post_processing.py 72.27% <41.66%> (-21.90%) ⬇️
superset/charts/api.py 85.82% <50.00%> (ø)
superset/reports/commands/execute.py 90.23% <62.50%> (-2.36%) ⬇️
superset/reports/notifications/slack.py 87.14% <80.00%> (+0.18%) ⬆️
superset/utils/csv.py 97.61% <90.00%> (-2.39%) ⬇️
superset/common/query_actions.py 92.95% <100.00%> (+0.10%) ⬆️
superset/reports/commands/exceptions.py 98.79% <100.00%> (+0.06%) ⬆️
superset/reports/notifications/email.py 100.00% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a284bb...09b9d01. Read the comment docs.

@betodealmeida betodealmeida merged commit afb8bd5 into apache:master Aug 19, 2021
betodealmeida added a commit to preset-io/superset that referenced this pull request Aug 19, 2021
* feat: improve HTML table in text reports

* Remove unused import

* Update tests

* Fix test
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
* feat: improve HTML table in text reports

* Remove unused import

* Update tests

* Fix test

(cherry picked from commit afb8bd5)
@villebro villebro added v1.3 and removed v1.3 labels Sep 22, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* feat: improve HTML table in text reports

* Remove unused import

* Update tests

* Fix test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* feat: improve HTML table in text reports

* Remove unused import

* Update tests

* Fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset:2021.31 size/XL 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants