-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve embedded data table in text reports #16335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #16335 +/- ##
==========================================
- Coverage 76.65% 76.37% -0.28%
==========================================
Files 999 1000 +1
Lines 53394 53458 +64
Branches 6817 6817
==========================================
- Hits 40929 40831 -98
- Misses 12228 12390 +162
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test
🏷 2021.31 |
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test (cherry picked from commit afb8bd5)
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test
SUMMARY
This PR improves the data table that is embedded in the email/slack notifications as text for reports.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Create a report as "text" and send to email.
ADDITIONAL INFORMATION