chore(pylint): Reenable too-many-locals check

[john-bodley]

SUMMARY

Re-enabling the Pylint too-many-locals check.

Note the goal is not to remedy existing code, i.e., I merely have added disabled checks locally, but rather to enforce future changes from using too many local variables which often makes the code difficult to grok.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16268 (ea4c5bc) into master (3709131) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #16268      +/-   ##
==========================================
- Coverage   76.70%   76.62%   -0.08%     
==========================================
  Files         997      997              
  Lines       53240    53240              
  Branches     6774     6774              
==========================================
- Hits        40838    40797      -41     
- Misses      12172    12213      +41     
  Partials      230      230              

Flag	Coverage Δ
hive	81.27% <100.00%> (-0.05%)	⬇️
mysql	81.56% <100.00%> (+0.04%)	⬆️
postgres	81.59% <100.00%> (ø)
presto	?
python	81.95% <100.00%> (-0.15%)	⬇️
sqlite	81.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/dashboards/api.py	93.03% <ø> (ø)
superset/datasets/api.py	91.92% <ø> (ø)
superset/utils/profiler.py	40.90% <ø> (ø)
superset/common/query_context.py	90.74% <100.00%> (ø)
superset/dashboards/commands/importers/v1/utils.py	80.59% <100.00%> (ø)
superset/examples/multiformat_time_series.py	16.66% <100.00%> (ø)
superset/utils/pandas_postprocessing.py	84.80% <100.00%> (ø)
superset/db_engine_specs/presto.py	84.51% <0.00%> (-5.86%)	⬇️
superset/connectors/sqla/models.py	88.28% <0.00%> (-1.43%)	⬇️
superset/models/core.py	89.14% <0.00%> (-0.26%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3709131...ea4c5bc. Read the comment docs.

[villebro]

I didn't remember this check was disabled (I assume it must have been disabled recently?). Anyway, I agree that this is a good check to at least remind the developer that the function is becoming loaded.