-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make dataset update methods static instead of global #16044
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16044 +/- ##
==========================================
- Coverage 76.90% 76.66% -0.25%
==========================================
Files 995 995
Lines 52842 52844 +2
Branches 6709 6709
==========================================
- Hits 40640 40513 -127
- Misses 11976 12105 +129
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@etr2460 Ephemeral environment spinning up at http://52.89.239.122:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Follow up to #15786 per @john-bodley's request. This seems cleaner
TESTING INSTRUCTIONS
CI, testenv
ADDITIONAL INFORMATION
to: @john-bodley @villebro