-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Celery to 5.1.2 #15927
chore: Bump Celery to 5.1.2 #15927
Conversation
f6c316b
to
2af7482
Compare
Codecov Report
@@ Coverage Diff @@
## master #15927 +/- ##
==========================================
- Coverage 77.05% 76.83% -0.23%
==========================================
Files 988 988
Lines 52180 52180
Branches 7095 7095
==========================================
- Hits 40209 40091 -118
- Misses 11746 11864 +118
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces a breaking change, per SIP-57. From the Celery 5.0 upgrade docs:
|
@john-bodley Hi John,I can see this changes had been reverted in an another PR(chore: Revert Celery 5 upgrade #16039). Is there any plan to upgrade to Celery 5 in near-future? |
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
SUMMARY
At Airbnb we're testing using the
celery beat
command for dedicated reporting. The issue we're running into is the application fails to beat after a period of time. Though there is no guarantee that this is an issue with Celery, I thought it was at least prudent to bump Celery as per the release history we're at least 12 months behind the latest release.TESTING INSTRUCTIONS
CI and verified that our docs, scripts, etc. have Celery 5.x compliant CLI commands.
ADDITIONAL INFORMATION