-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds the tests that need to be coded for the Select component #15885
chore: Adds the tests that need to be coded for the Select component #15885
Conversation
98b0318
to
e200e1c
Compare
Hey. Would you like to add an initial test to this maybe? even just checking that the component renders? Otherwise this looks a bit dry ;p |
e200e1c
to
d464c25
Compare
Done. |
Codecov Report
@@ Coverage Diff @@
## master #15885 +/- ##
==========================================
- Coverage 77.08% 77.08% -0.01%
==========================================
Files 984 984
Lines 51787 51791 +4
Branches 7031 7037 +6
==========================================
+ Hits 39918 39921 +3
- Misses 11644 11645 +1
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... thanks for these comments. Fleshing these out will be much easier to collaborate on now.
SUMMARY
Adds the tests that need to be coded for the
Select
component.@junlincc @rusackas @geido
ADDITIONAL INFORMATION