chore: Select component refactoring - FilterControl - Iteration 5

[geido]

SUMMARY

It replaces the react-select Select component with the Antdesign one in the FilterControl components.

BEFORE/AFTER

AdhocFilterEditPopoverSimpleTabContent.-.BEFORE.mp4

AdhocFilterEditPopoverSimpleTabContent.-.AFTER-new.mp4

BEFORE/AFTER

AdhocFilterEditPopoverSqlTabContent.-.BEFORE.mp4

AdhocFilterEditPopoverSimpleTabContent.-.AFTER.mp4

TESTING INSTRUCTIONS

1. Open a chart in Explore
2. Add Filters using the SIMPLE tab options and observe the behavior
3. Add Filters using the CUSTOM SQL options and observe the behavior

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[geido]

@rosemarie-chiu @jinghua-qa

[codecov]

Codecov Report

Merging #15777 (cd5444f) into master (88c09c2) will increase coverage by 0.02%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master   #15777      +/-   ##
==========================================
+ Coverage   76.90%   76.92%   +0.02%     
==========================================
  Files        1007     1007              
  Lines       54109    54087      -22     
  Branches     7369     7360       -9     
==========================================
- Hits        41612    41608       -4     
+ Misses      12257    12239      -18     
  Partials      240      240              

Flag	Coverage Δ
javascript	71.33% <77.77%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ols/FilterControl/AdhocFilterEditPopover/index.jsx	68.33% <ø> (-1.03%)	⬇️
...trol/AdhocFilterEditPopoverSqlTabContent/index.jsx	62.50% <66.66%> (+1.20%)	⬆️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx	72.97% <79.16%> (+7.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c09c2...cd5444f. Read the comment docs.

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://34.209.229.173:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

/testenv up

[github-actions]

@michael-s-molina Ephemeral environment spinning up at http://54.184.73.197:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

I think we need to clear the filter value when changing the column.

Screen.Recording.2021-09-15.at.6.19.33.PM.mov

[pkdotson]

The code lgtm. But in regards to clearing the fields like @michael-s-molina suggested would be nice but to be fair it doesn't currently do that on master so I think that could be done as a follow up as that might require a little more refactoring work?

[geido]

I think we need to clear the filter value when changing the column.

@michael-s-molina Just tested on master. As @pkdotson reported this is currently not implemented. I think it makes sense to tackle that in a separate PR as it would be slightly unrelated to the objective of this PR. I'll work on that as soon as we merge this PR.

[michael-s-molina]

I think we need to clear the filter value when changing the column.

@michael-s-molina Just tested on master. As @pkdotson reported this is currently not implemented. I think it makes sense to tackle that in a separate PR as it would be slightly unrelated to the objective of this PR. I'll work on that as soon as we merge this PR.

Ok. Approving with the follow-up in mind.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.