Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add show columns to Reports model #15712

Merged
merged 6 commits into from
Jul 19, 2021
+4 −1
Merged

feat: add show columns to Reports model #15712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b5a3123
added logic for creation_method
AAfghahi Jul 14, 2021
0c146de
revisions
AAfghahi Jul 14, 2021
e2330d9
added index
AAfghahi Jul 14, 2021
2ca3c50
Update superset/migrations/versions/3317e9248280_add_creation_method_…
AAfghahi Jul 14, 2021
ed4be29
filters
AAfghahi Jul 15, 2021
8954e1d
search columns updated
AAfghahi Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions superset/reports/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ def ensure_alert_reports_enabled(self) -> Optional[Response]:
"created_by",
"type",
"last_state",
"creation_method",
"dashboard_id",
"chart_id",
]
search_filters = {"name": [ReportScheduleAllTextFilter]}
allowed_rel_fields = {"owners", "chart", "dashboard", "database", "created_by"}
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/reports/api_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ def test_create_report_schedule_relations_exist(self):
data = json.loads(rv.data.decode("utf-8"))
assert data == {"message": {"dashboard": "Dashboard does not exist"}}

@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
# @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
# TODO (AAfghahi): I am going to enable this when the report schedule feature is fully finished
# def test_create_report_schedule_no_creation_method(self):
# """
Expand Down