Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for headeractionsdropdown #15560

Merged
merged 4 commits into from
Jul 7, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 6, 2021

SUMMARY

This pr refactors the icon to icons component for the headeractionsdropdown more-horiz icon.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2021-07-06 at 2 49 10 PM

after
Screen Shot 2021-07-06 at 3 07 03 PM

TESTING INSTRUCTIONS

Go to a dashboard to test the new icon

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #15560 (ed6adf3) into master (314d49c) will increase coverage by 0.08%.
The diff coverage is 35.71%.

❗ Current head ed6adf3 differs from pull request most recent head 2ba72fe. Consider uploading reports for the commit 2ba72fe to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15560      +/-   ##
==========================================
+ Coverage   76.86%   76.95%   +0.08%     
==========================================
  Files         976      976              
  Lines       51320    51291      -29     
  Branches     6912     6907       -5     
==========================================
+ Hits        39446    39469      +23     
+ Misses      11655    11603      -52     
  Partials      219      219              
Flag Coverage Δ
javascript 71.41% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.15% <28.00%> (-5.89%) ⬇️
.../components/Header/HeaderActionsDropdown/index.jsx 67.50% <100.00%> (+0.41%) ⬆️
superset/app.py 83.33% <100.00%> (+19.84%) ⬆️
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
superset/models/core.py 90.02% <0.00%> (+0.26%) ⬆️
superset/connectors/sqla/models.py 89.90% <0.00%> (+1.40%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+5.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 314d49c...2ba72fe. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 7, 2021
@pkdotson pkdotson merged commit 29dd084 into apache:master Jul 7, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* initial commit

* fix test

* fix cypress

* fix markdown cypress test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* initial commit

* fix test

* fix cypress

* fix markdown cypress test
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* initial commit

* fix test

* fix cypress

* fix markdown cypress test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants