-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons for headeractionsdropdown #15560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15560 +/- ##
==========================================
+ Coverage 76.86% 76.95% +0.08%
==========================================
Files 976 976
Lines 51320 51291 -29
Branches 6912 6907 -5
==========================================
+ Hits 39446 39469 +23
+ Misses 11655 11603 -52
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
Show resolved
Hide resolved
* initial commit * fix test * fix cypress * fix markdown cypress test
* initial commit * fix test * fix cypress * fix markdown cypress test
* initial commit * fix test * fix cypress * fix markdown cypress test
SUMMARY
This pr refactors the icon to icons component for the headeractionsdropdown more-horiz icon.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before

after

TESTING INSTRUCTIONS
Go to a dashboard to test the new icon
ADDITIONAL INFORMATION