refactor: icon to icons for nativeFilter components #15528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15528 +/- ##
==========================================
- Coverage 77.24% 76.95% -0.30%
==========================================
Files 975 976 +1
Lines 50866 51289 +423
Branches 6740 6907 +167
==========================================
+ Hits 39293 39468 +175
- Misses 11357 11602 +245
- Partials 216 219 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
suddjian
reviewed
Jul 2, 2021
...end/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx
Outdated
Show resolved
Hide resolved
geido
reviewed
Jul 4, 2021
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabs.tsx
Show resolved
Hide resolved
...end/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx
Outdated
Show resolved
Hide resolved
fintzd
reviewed
Jul 5, 2021
…rBar/CascadeFilters/CascadePopover/index.tsx Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
|
@pkdotson Ephemeral environment spinning up at http://34.221.155.212:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* initial commit for cascade filters * migrate delete icon * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * add uniform style for icons * fix lint Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* initial commit for cascade filters * migrate delete icon * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * add uniform style for icons * fix lint Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* initial commit for cascade filters * migrate delete icon * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * add uniform style for icons * fix lint Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr migrates the icons for native filters to the new icons component. The delete icon in the filter config modal and the icons in the cross filter componets.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Test in the filterconfig modal and the crossfilter propover
ADDITIONAL INFORMATION