-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: base requirements missing deprecation pkg #15527
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15527 +/- ##
==========================================
- Coverage 76.97% 76.83% -0.14%
==========================================
Files 976 976
Lines 51250 51260 +10
Branches 6897 6900 +3
==========================================
- Hits 39450 39387 -63
- Misses 11581 11654 +73
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, is the bot (Codecov) only raising a warning due to the minimal decreased coverage, which in turn is due to the deprecation? (just wanted to check if I got this right) Thanks!
don't think it's because of the deprecation, see no reason for coverage decrease, maybe it has to finish all tests first |
Thank you @dpgaspar ! Sorry, I'm new to this repo and have not worked with this Codecov yet! |
SUMMARY
Add missing
deprecation
package to requirements base. Also nit sort onsetup.py
ADDITIONAL INFORMATION