-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): add new tab when add sql query #15492
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15492 +/- ##
=======================================
Coverage 77.20% 77.20%
=======================================
Files 975 975
Lines 50842 50842
Branches 6728 6728
=======================================
Hits 39251 39251
Misses 11376 11376
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.216.105.186:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Add new tab when click on
+sql query
on welcome page.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2021-07-01.4.24.31.mov
after
2021-07-01.4.31.44.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION