fix: quote column name if db requires

[eschutho]

SUMMARY

We were seeing some issues when using Snowflake with column aliases in quotes. When creating the dataset, the outer select statement was quoting the alias/label but not the column name. Snowflake in particular requires that if the original query column name is quoted then any reference to it must also be quoted.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before with quotes (snowflake)

Before without quotes (snowflake):

After with quotes (snowflake):

After without quotes (snowflake):

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[eschutho]

These changes will also affect db2, hana, and oracle which I haven't tested. I'd be grateful if someone could test another db that has access to one or more of them.

[codecov]

Codecov Report

Merging #15465 (76e3906) into master (e5ab9a4) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #15465      +/-   ##
==========================================
- Coverage   76.97%   76.92%   -0.05%     
==========================================
  Files         976      974       -2     
  Lines       51260    50511     -749     
  Branches     6900     6494     -406     
==========================================
- Hits        39456    38857     -599     
+ Misses      11585    11449     -136     
+ Partials      219      205      -14     

Flag	Coverage Δ
hive	?
mysql	81.62% <100.00%> (+<0.01%)	⬆️
postgres	81.64% <100.00%> (+<0.01%)	⬆️
presto	?
python	81.72% <100.00%> (-0.45%)	⬇️
sqlite	81.25% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/connectors/sqla/models.py	88.24% <100.00%> (-1.63%)	⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx	0.00% <0.00%> (-92.31%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
...tend/src/filters/components/Time/transformProps.ts	22.22% <0.00%> (-44.45%)	⬇️
...d/src/dashboard/components/FiltersBadge/Styles.tsx	54.05% <0.00%> (-40.82%)	⬇️
...uperset-frontend/src/components/Form/FormLabel.tsx	64.70% <0.00%> (-35.30%)	⬇️
superset/db_engine_specs/hive.py	69.20% <0.00%> (-17.21%)	⬇️
.../database/DatabaseModal/DatabaseConnectionForm.tsx	48.48% <0.00%> (-14.62%)	⬇️
...nd/src/components/SupersetResourceSelect/index.tsx	70.96% <0.00%> (-12.91%)	⬇️
...rset-frontend/src/filters/components/Time/index.ts	88.88% <0.00%> (-11.12%)	⬇️
... and 126 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ab9a4...76e3906. Read the comment docs.

[betodealmeida]

Looks great! I pinged #debug-together asking for people who might be able to test in the other DBs, but I wouldn't hold my breath.

[villebro]

@eschutho did you make sure this also works with physical tables? If memory serves me well, I believe this problem only currently affects virtual tables, and when I tried to fix the virtual table problem, it broke physical tables. So just to be sure, it would be nice to test that this also works on physical tables with all lowercase, all uppercase and mixed case column names.

[yousoph]

We were able to repro on a physical table before this fix. I did some additional testing of this with physical and virtual tables, and lower/upper/mixed case column aliases, it was looking good in all those cases :)