-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Removed jsx-remove-data-test-id usage from code for multi-build-variant testing #15386
build: Removed jsx-remove-data-test-id usage from code for multi-build-variant testing #15386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15386 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 983 983
Lines 51618 51618
Branches 6991 6991
=======================================
Hits 39785 39785
Misses 11608 11608
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@rusackas Can we proceed with this change? |
04a03b8
to
5f6e65f
Compare
@rusackas I added an option to force different configuration from command line and added extra babel configuration which does not use trimming if someone wants to build production but without this plugin. |
…d-variant testing (apache#15386) * enabled customized production build with testIds * fix for docker * changed substitution * changed substitution
…d-variant testing (apache#15386) * enabled customized production build with testIds * fix for docker * changed substitution * changed substitution
SUMMARY
I disabled babel option to remove data-test from non-development builds.
Thanks to this change it would be possible to easier write any kind of black box e2e tests for non-dev deployments.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION