-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extra table metadata for Google Sheets #14775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b00466
to
24046a5
Compare
35a0828
to
64689be
Compare
ac63af1
to
0f68d39
Compare
0f68d39
to
ddacd32
Compare
Codecov Report
@@ Coverage Diff @@
## master #14775 +/- ##
==========================================
- Coverage 77.24% 76.96% -0.29%
==========================================
Files 975 976 +1
Lines 50866 51238 +372
Branches 6740 6895 +155
==========================================
+ Hits 39293 39433 +140
- Misses 11357 11586 +229
- Partials 216 219 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
99ba847
to
ddacd32
Compare
94fb5f4
to
0791583
Compare
0791583
to
a7d0c5a
Compare
hughhhh
approved these changes
Jul 2, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* feat: GSheets extra table metadata * Bump version
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* feat: GSheets extra table metadata * Bump version
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* feat: GSheets extra table metadata * Bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR uses the new
GET_METADATA
function inshillelagh
0.7.0 to show extra metadata about spreadsheets in the metadata browser in SQL Lab, namely the Spreadsheet and Sheet (tab) titles.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION