Allow user to extend shrunken sql text in Query Table #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: apache#1218 Done: - Added state HighlightedSql component - Added button at the end of each sql for extending/shrinking sql text
|
Oh I have something similar on #1426 where I pop a modal that shows the unshrunk SQL as well as the "executedSQL" if it is different, mostly when using templates. |
|
Ahhhh the modal seems like a better option, I'll close this one. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…1430) * Revert "feat: add default series_limit (apache#1033)" This reverts commit 5bd2a149644e9ecfeca8e54153eb9e5658546ec3. * Update index.tsx * Update index.tsx
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…1430) * Revert "feat: add default series_limit (apache#1033)" This reverts commit 5bd2a149644e9ecfeca8e54153eb9e5658546ec3. * Update index.tsx * Update index.tsx
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…1430) * Revert "feat: add default series_limit (apache#1033)" This reverts commit 5bd2a149644e9ecfeca8e54153eb9e5658546ec3. * Update index.tsx * Update index.tsx
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…1430) * Revert "feat: add default series_limit (apache#1033)" This reverts commit 5bd2a149644e9ecfeca8e54153eb9e5658546ec3. * Update index.tsx * Update index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1218
User case: currently the sql text in query table is default to be shrunken, but users might want to view full sql in some cases.
Done:
before clicking on plus sign at end of sql text:
after:
needs-review @mistercrunch @ascott @bkyryliuk