Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: split python CI jobs #11794

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Nov 24, 2020

SUMMARY

The Python CI job currently has 10 tasks within it that all need to be retried if any one of them fails. By splitting CI up, it'll make it easier to retry when one of our flaky tests fails

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @ktmud @mistercrunch @john-bodley

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #11794 (86cbbe8) into master (872a54d) will decrease coverage by 4.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11794      +/-   ##
==========================================
- Coverage   67.29%   63.26%   -4.04%     
==========================================
  Files         905      448     -457     
  Lines       43862    27560   -16302     
  Branches     4201        0    -4201     
==========================================
- Hits        29519    17435   -12084     
+ Misses      14239    10125    -4114     
+ Partials      104        0     -104     
Flag Coverage Δ
cypress ?
javascript ?
python 63.26% <ø> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.08% <0.00%> (-29.97%) ⬇️
superset/db_engine_specs/presto.py 81.64% <0.00%> (-0.65%) ⬇️
superset/views/base_api.py 97.61% <0.00%> (-0.48%) ⬇️
superset/models/core.py 88.58% <0.00%> (-0.28%) ⬇️
...t-frontend/src/components/Select/OnPasteSelect.jsx
...rontend/src/dashboard/reducers/dashboardFilters.js
...t-frontend/src/views/CRUD/data/query/QueryList.tsx
...rc/dashboard/components/gridComponents/Divider.jsx
...frontend/src/profile/components/RecentActivity.tsx
... and 452 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872a54d...86cbbe8. Read the comment docs.

# Python unit tests
name: Python
# Python Misc unit tests
name: Python Misc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename the file to superset-python-misc.yml, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@etr2460 etr2460 merged commit 67c4447 into apache:master Nov 24, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants