docs: Add supported database logos #10368
Conversation
Adding logos of supported database solutions to make README more visual and easier to use
README.md
Outdated
| SQL toolkit that is compatible with most databases. Here are some of the major database solutions that are supported: | ||
|
|
||
| <p float="left"> | ||
| <img src="https://i.ibb.co/qYyYdsr/redshift.png" alt="redshift" border="0" width="106" height="41" /> |
There was a problem hiding this comment.
are these urls ever going to break? Can we add the images to the repo under the apache license?
There was a problem hiding this comment.
It's a free imaging hosting site that appears good, so I used it to get this PR going, since I can't upload files to this repo.
If you can upload files to this repo and prefer that way, I can send you the images for you to upload, then I'll fix this PR with the relative links. Just let me know what you prefer! :)
There was a problem hiding this comment.
Never heard of https://i.ibb.co, wouldn't rely on it.
Your images can be part of this PR (if you can PR you can add images).
Codecov Report
@@ Coverage Diff @@
## master #10368 +/- ##
==========================================
- Coverage 70.63% 65.62% -5.02%
==========================================
Files 601 604 +3
Lines 32338 32445 +107
Branches 3275 3285 +10
==========================================
- Hits 22843 21293 -1550
- Misses 9390 10966 +1576
- Partials 105 186 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Upload logos to repo and updated links. PTAL @etr2460 Thank you. |
There was a problem hiding this comment.
I'd recommend putting these images in a bit more generically named directory (maybe readme-assets or documentation-assets) but otherwise this lgtm
Although I would like confirmation from @mistercrunch (or someone else) that we can include these images within the repo under Apache's license?
|
I'd recommend putting them under <img src="supported-frontend/images/supported-databases/redshift.png" alt="redshift" border="0" width="106" height="41"/> |
|
@ktmud My thought was that we shouldn't include them in the package as they're not required for actually running Superset. It seems like keeping them seperate from the package would be better |
|
I can see these images potentially being useful for the future doc site or when the Superset app adds a more graphic "add a datasource" page like Redash: https://redash.io/help/user-guide/getting-started#1-Add-A-Data-Source Currently |
|
yikes, didn't realize we were packaging all the docs images in superset-frontend.... That's probably not a good idea in the long run. However, I do see your point to there being value in including the images within the app. Moving to |
Add supported database logos to superset-frontend/images
|
Moved logos to |
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
SUMMARY
Adding logos of supported database solutions to make README more visual and easier to use.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION