Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report selection menu doesn't disappear when clicked from Chart or Dashboard #24493

Closed
3 tasks done
yousoph opened this issue Jun 23, 2023 · 0 comments
Closed
3 tasks done

Report selection menu doesn't disappear when clicked from Chart or Dashboard #24493

yousoph opened this issue Jun 23, 2023 · 0 comments
Labels
bug-bash

Comments

@yousoph
Copy link
Member

yousoph commented Jun 23, 2023

How to reproduce the bug

  1. Open a chart or a dashboard
  2. Click the ... in the top right
  3. Click "Manage Email Report"
  4. Click "Set up email report"

Expected results

The menu should disappear once the modal opens

Actual results

The "Set up an email report" menu option doesn't disappear

Screenshots

image (118)

Environment

  • browser type and version:
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active: ALERT_REPORTS

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
michael-s-molina pushed a commit that referenced this issue Sep 5, 2023
@sandeep-patel11
fix: Issue #24493; Resolved report selection menu in chart and dashbo…
d030544 
…ard page (#25157)
michael-s-molina pushed a commit that referenced this issue Sep 6, 2023
@sandeep-patel11 @michael-s-molina
fix: Issue #24493; Resolved report selection menu in chart and dashbo…
e77bc06 
…ard page (#25157)

(cherry picked from commit d030544)
darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this issue Sep 7, 2023
@sandeep-patel11 @darwinsubramaniam
fix: Issue apache#24493; Resolved report selection menu in chart and …
6a2a0d4 
…dashboard page (apache#25157)
sebastiankruk added a commit to sebastiankruk/superset that referenced this issue Sep 9, 2023
@sebastiankruk @sandeep-patel11
@hughhhh @michael-s-molina @cmontemuino @dpgaspar @eschutho @justinpark @sfirke @betodealmeida @giftig @kgabryje @yousoph @villebro
sync (#160)
4463d38 
* fix: Issue apache#24493; Resolved report selection menu in chart and dashboard page (apache#25157)

* fix: DML failures in SQL Lab (apache#25190)

* fix: All values being selected in Select (apache#25202)

* docs: fix wrong type in PREFERRED_DATABASES example (apache#25200)

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>

* docs: add CVEs for 2.1.1 (apache#25206)

* chore: back port 2.1.1 doc changes (apache#25165)

* feat(sqllab): Show sql in the current result (apache#24787)

* docs(FAQ): add answer re: necessary specs, copy-edit existing answer (apache#24992)

* fix: `is_select` (apache#25189)

* fix: Cypress test to force mouseover (apache#25209)

* fix(sqllab): Force trino client async execution (apache#24859)

* fix: granularity_sqla and GENERIC_CHART_AXES (apache#25213)

* chore: Convert deckgl class components to functional (apache#25177)

* fix: Cypress test to force mouseover (follow-up) (apache#25223)

* fix(docs): Fixing a typo in README.md (apache#25216)

* chore(read_csv): remove deprecated argument (apache#25226)

* chore(trino): remove unnecessary index checks (apache#25211)

---------

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
Co-authored-by: Sandeep Patel <33354423+suicide11@users.noreply.github.com>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Carlos M <1761056+cmontemuino@users.noreply.github.com>
Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Rob Moore <giftig@users.noreply.github.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: yousoph <sophieyou12@gmail.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@yousoph yousoph closed this as completed Sep 26, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this issue Mar 6, 2024
@sandeep-patel11
fix: Issue apache#24493; Resolved report selection menu in chart and …
f7607d7 
…dashboard page (apache#25157)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this issue Nov 11, 2024
@sandeep-patel11
fix: Issue apache#24493; Resolved report selection menu in chart and …
9773beb 
…dashboard page (apache#25157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-bash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yousoph