Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Lab cancel query in Redshift database connection does not work #16325

Closed
yourssvk opened this issue Aug 18, 2021 · 6 comments
Closed

SQL Lab cancel query in Redshift database connection does not work #16325

yourssvk opened this issue Aug 18, 2021 · 6 comments
Assignees
@AAfghahi
Labels
good first issue Good first issues for new contributors

Comments

@yourssvk
Copy link
Contributor

yourssvk commented Aug 18, 2021 •
edited
Loading

Issue:

Cancel query in Redshift queries does not work

Steps to reproduce the issue:

  1. Create a Redshift Database connection in Superset
  2. Run a long-running query on the Redshift Database connection on SQL Lab
  3. Try to cancel the query in the middle of execution and check the Redshift Running queries and the query may not be killed.
  4. The only option to kill the query is to kill it from Redshift administrative console.

Expected results:

The query is cancelled and the transaction is rolled back on Redshift database

Actual results:

The query is left running on Redshift
@yourssvk yourssvk changed the title Cancel query in Redshift queries does not work SQL Lab cancel query in Redshift database connection does not work Aug 18, 2021
yourssvk pushed a commit to yourssvk/superset that referenced this issue Aug 18, 2021
fix: SQL Lab cancel query in Redshift database connection does not work
8e93d03 
apache#16325
@yourssvk yourssvk mentioned this issue Aug 18, 2021
Merged
9 tasks
@srinify srinify added the good first issue Good first issues for new contributors label Aug 25, 2021
@srinify srinify closed this as completed Aug 25, 2021
@srinify srinify reopened this Aug 25, 2021
@matrixhead
Copy link

hey, can i work on this

@yourssvk
Copy link
Contributor Author

yourssvk commented Sep 6, 2021 via email

@yourssvk
Copy link
Contributor Author

@AAfghahi any further update on this issue?

@AAfghahi
Copy link
Member

Hi! I was assigned so that I could redirect a newer engineer to this ticket. I don't think that they ended up getting to it, but I can prioritize it :)

@yourssvk
Copy link
Contributor Author

Thanks @AAfghahi - please :-)

eschutho added a commit that referenced this issue Jun 29, 2022
@yourssvk @eschutho
fix: SQL Lab cancel query in Redshift database connection does not wo… (
90d486a 
#16326)

* fix: SQL Lab cancel query in Redshift database connection does not work #16325


Co-authored-by: Venkata Krishnan Somasundaram <venkata_cred@Venkatas-MacBook-Pro.local>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
@michael-s-molina
Copy link
Member

Fixed by #16326

michael-s-molina pushed a commit that referenced this issue Jul 6, 2022
@yourssvk @michael-s-molina
fix: SQL Lab cancel query in Redshift database connection does not wo… (
9a26a21 
#16326)

* fix: SQL Lab cancel query in Redshift database connection does not work #16325

Co-authored-by: Venkata Krishnan Somasundaram <venkata_cred@Venkatas-MacBook-Pro.local>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
(cherry picked from commit 90d486a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AAfghahi AAfghahi

Labels
good first issue Good first issues for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@srinify @yourssvk @AAfghahi @matrixhead @michael-s-molina