Skip to content

Commit

Permalink
refactor charts api tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ofekisr committed Nov 14, 2021
1 parent e68b55e commit cdbcbf3
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions tests/integration_tests/charts/data/api_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def test_with_csv_result_format_when_actor_not_permitted_for_csv__403(self):
assert rv.status_code == 403

@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_chart_data_limit_offset(self):
def test_with_row_limit_and_offset__row_limit_and_offset_were_applied(self):
"""
Chart data API: Test chart data query with limit and offset
"""
Expand All @@ -262,9 +262,8 @@ def test_chart_data_limit_offset(self):
self.query_context_payload["queries"][0]["orderby"] = [["name", True]]

rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")
response_payload = json.loads(rv.data.decode("utf-8"))
result = response_payload["result"][0]
self.assertEqual(result["rowcount"], 5)
self.assert_row_count(rv, 5)
result = rv.json["result"][0]

# TODO: fix offset for presto DB
if get_example_database().backend == "presto":
Expand All @@ -275,10 +274,9 @@ def test_chart_data_limit_offset(self):
expected_name = result["data"][offset]["name"]
self.query_context_payload["queries"][0]["row_offset"] = offset
rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")
response_payload = json.loads(rv.data.decode("utf-8"))
result = response_payload["result"][0]
self.assertEqual(result["rowcount"], 5)
self.assertEqual(result["data"][0]["name"], expected_name)
result = rv.json["result"][0]
assert result["rowcount"] == 5
assert result["data"][0]["name"] == expected_name

@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_chart_data_applied_time_extras(self):
Expand Down Expand Up @@ -308,8 +306,6 @@ def test_chart_data_applied_time_extras(self):
expected_row_count = self.get_expected_row_count("client_id_2")
self.assertEqual(data["result"][0]["rowcount"], expected_row_count)

# Test chart csv without permission

@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_with_in_op_filter__data_is_returned(self):
"""
Expand Down

0 comments on commit cdbcbf3

Please sign in to comment.