fix: Menu does not appear on scroll in Dashboard (#14566)

* Fix menu * Fix test
apache · May 11, 2021 · b960843 · b960843
1 parent eaeb8f7
commit b960843
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/...tend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx b/...tend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
@@ -65,7 +65,7 @@ const editModeOnProps = {
 
 function setup(props: HeaderDropdownProps) {
   return (
-    <div className="dashboard">
+    <div className="dashboard-header">
       <HeaderActionsDropdown {...props} />
     </div>
   );

diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
@@ -317,7 +317,7 @@ class HeaderActionsDropdown extends React.PureComponent {
         overlay={menu}
         trigger={['click']}
         getPopupContainer={triggerNode =>
-          triggerNode.closest(SCREENSHOT_NODE_SELECTOR)
+          triggerNode.closest('.dashboard-header')
         }
       >
         <DropdownButton id="save-dash-split-button" role="button">

diff --git a/superset-frontend/stylesheets/superset.less b/superset-frontend/stylesheets/superset.less
@@ -603,7 +603,3 @@ hr {
     top: 269px !important;
   }
 }
-
-.ant-dropdown.ant-dropdown-placement-bottomRight {
-  top: 133px !important;
-}