Skip to content

Commit

Permalink
fix: Provide more inclusive error handling for saved queries
Browse files Browse the repository at this point in the history
  • Loading branch information
john-bodley authored Mar 25, 2024
1 parent 4fce940 commit b43745e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions superset/models/sql_lab.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
from sqlalchemy.sql.elements import ColumnElement, literal_column

from superset import security_manager
from superset.exceptions import SupersetSecurityException
from superset.jinja_context import BaseTemplateProcessor, get_template_processor
from superset.models.helpers import (
AuditMixinNullable,
Expand Down Expand Up @@ -76,7 +75,7 @@ def sql_tables(self) -> list[Table]:
self.database.db_engine_spec.engine, # type: ignore
)
)
except SupersetSecurityException:
except Exception: # pylint: disable=broad-except

Check warning on line 78 in superset/models/sql_lab.py

View check run for this annotation

Codecov / codecov/patch

superset/models/sql_lab.py#L78

Added line #L78 was not covered by tests
return []


Expand Down

0 comments on commit b43745e

Please sign in to comment.